Avoids linking nghttp2 in Carthage project #450
Conversation
patch-carthage-project.rb
Outdated
| # 2) Prevent linking of nghttp2 library | ||
| carthage_nghttp2_unlink_targets = [ "BoringSSL", "CgRPC", "SwiftGRPC" ] | ||
| targets_to_unlink = project.targets.select { |target| carthage_nghttp2_unlink_targets.include?(target.name) } | ||
| ldflags_to_remove = [ "-L/usr/local/Cellar/nghttp2/1.38.0/lib", "-lnghttp2" ] |
There was a problem hiding this comment.
Would it be possible to make this more generic, removing any LDFLAG containing nghttp2?
There was a problem hiding this comment.
I can scan every target in the scheme if that is all right with you
There was a problem hiding this comment.
Sounds good, but I was more thinking of removing any flag that contains nghttp2, even if there is not an exact match.
| @@ -1,4 +1,4 @@ | |||
| module CNIONghttp2 { | |||
| umbrella "/Users/mrebello/Development/grpc-swift/.build/checkouts/swift-nio-http2.git-1684232237084789971/Sources/CNIONghttp2/include" | |||
There was a problem hiding this comment.
I'm a bit surprised by all the .git-1684232237084789971 suffixes disappearing. I'd expect the values to have changed, but that there would still be a suffix present. Which Swift version did you use to generate the new project? (I think we should stick with Swift 4.2 for now, to ensure that we don't break the build for Swift 4.2 users by generating the project with Swift 5.) See https://medium.com/xcblog/switching-swift-versions-inside-xcode-using-toolchains-755b28831c43 on selecting the Swift 4.2 toolchain.
There was a problem hiding this comment.
Of course: I'm using swift 5. I'll fix that
- makes nghttp2 flag search more generic (also searches in all available targets) - uses swift 4.2 toolchain
* Avoids linking nghttp2 in Carthage project * Applies the following fixes - makes nghttp2 flag search more generic (also searches in all available targets) - uses swift 4.2 toolchain
This should address #449