Skip to content

Conversation

Krivoblotsky
Copy link
Contributor

@Krivoblotsky Krivoblotsky commented Jul 30, 2019

What

Fix possible Int overflow when building for 32-bit architectures by increasing the size to Int64.
See related issue #534

Why

The build is failing and overflow issues are possible

Affected Areas

Timestamp generation in GRPCTimeout.swift

@MrMage
Copy link
Collaborator

MrMage commented Jul 30, 2019

Thank you!

@saudeoncovr
Copy link

saudeoncovr commented Aug 6, 2019

@MrMage are we able to get a new 1.0.0-alpha.3 tagged release that includes this and #538? Or even @glbrntt?

Unfortunately our CI is failing to compile due to the Int overflow error.

@MrMage
Copy link
Collaborator

MrMage commented Aug 7, 2019

@MrMage are we able to get a new 1.0.0-alpha.3 tagged release that includes this and #538? Or even @glbrntt?

Unfortunately our CI is failing to compile due to the Int overflow error.

That might be possible. Until then, could you simply point your Package.swift to the nio branch instead of a specific version?

@glbrntt
Copy link
Collaborator

glbrntt commented Aug 7, 2019

Fine with me if you don't mind cutting it @MrMage :)

@MrMage
Copy link
Collaborator

MrMage commented Aug 7, 2019

Done: https://github.com/grpc/grpc-swift/releases/tag/1.0.0-alpha.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants