Split the Echo example into model, implementation and runtime #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The generated code and implementation for the Echo example is used as part of the example and as well as in the test suite. To make the example more obvious we should split it into its constituent parts: the model (i.e. the definition and generated code), the implementation (of the server), and the runtime (CLI for client and server). Modifications: - Split the Echo example into three modules: `EchoModel` (generated code), `EchoImplementation` (server implementation), and `EchoRuntime` (CLI for client and server). - Update the `Makefile` to target the updated paths - Add missing imports in tests - Make the generated code `public` (instead of `internal`) since we're no longer symlinking into the same module for tests Result: - No more symlinks for Echo - Structure of example is more straightforward
|
Looks good, but do you think we could merge |
|
I think it's better to keep them separate; it makes the separation of generation and implementation really obvious (i.e. for someone who's new to gRPC). WDYT? |
|
Fine with me :-) |
MrMage
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The generated code and implementation for the Echo example is used as
part of the example and as well as in the test suite. To make the
example more obvious we should split it into its constituent parts: the
model (i.e. the definition and generated code), the implementation (of
the server), and the runtime (CLI for client and server).
Modifications:
EchoModel(generated code),EchoImplementation(server implementation), andEchoRuntime(CLI forclient and server).
Makefileto target the updated pathspublic(instead ofinternal) since we'reno longer symlinking into the same module for tests
Result: