Update minimum Swift NIO version #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The minimum NIO version is quite old and there have been a number of bug fixes since which have fixed issues we've seen in gRPC. We should enforce users to use a newer version so that they will not see these issues. Modifications: - Update our minimum NIO version to 2.7.1. - Also bump gRPC alpha version in README Result: NIO is more up-to-date.
|
@MrMage mind if we cut another release following this PR? |
MrMage
approved these changes
Sep 3, 2019
|
Feel free to merge and cut a release :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The minimum NIO version is quite old and there have been a number of bug
fixes since which have fixed issues we've seen in gRPC. We should
enforce users to use a newer version so that they will not see these
issues.
Modifications:
Result:
NIO is more up-to-date.