Rename the plugin: protoc-gen-swiftgrpc -> protoc-gen-grpc-swift #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We refer to this package as 'grpc-swift', the 'protoc' plugin should be consistent with this. The plugin was also not listed as a product of the package which means that a dependency is not able to build the plugin withough checking out the repository. Modifications: - Rename the protoc plugin to 'protoc-gen-grpc-swift'. - Update references to this. - Include the plugin as an executable product. Result: - More consistent naming. - It is possible to build the plugin with `swift build --product protoc-gen-grpc-swift` when grpc-swift is used as a dependency.
|
|
MrMage
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We refer to this package as 'grpc-swift', the 'protoc' plugin should be
consistent with this.
The plugin was also not listed as a product of the package which means
that a dependency is not able to build the plugin withough checking out
the repository.
Modifications:
Result:
swift build --product protoc-gen-grpc-swiftwhen grpc-swift is used as adependency.