Allow client error delegate to have a logger injected #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When errors are logged it's useful to have some contextual information. We can enable this by injecting a `logger` into the error delegate. Modifications: Change the API for the `ClientErrorDelegate` to also pass in a logger. Remove additional logging from next to the call to the delegate. Result: Users can log errors with more contextual information in the delegate.
MrMage
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When errors are logged it's useful to have some contextual information.
We can enable this by injecting a
loggerinto the error delegate.Modifications:
Change the API for the
ClientErrorDelegateto also pass in a logger.Remove additional logging from next to the call to the delegate.
Result:
Users can log errors with more contextual information in the delegate.