Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for watchOS to the podspecs #998

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

daltonclaybrook
Copy link
Contributor

grpc-swift is able to support watchOS 6+ with NIO Transport Services and Network.framework, but the podspecs do not declare such support, so it cannot be used in a watchOS app through CocoaPods. This PR adds the necessary support to each of the three podspecs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 15, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @daltonclaybrook -- the podspecs are generated by /scripts/build_podspecs.py, would you mind updating the script instead?

Also, I'm curious, have you actually tried gRPC on watchOS? It's something I've been meaning to do but haven't yet found the time for.

@glbrntt glbrntt added the semver/none No version bump required. label Oct 16, 2020
@daltonclaybrook
Copy link
Contributor Author

@glbrntt I'd be happy to do that.

have you actually tried gRPC on watchOS?

Yes! It works really well and I've been super pleased with it. This was the crucial step for me to get it working. Though, it seems I may have one final hurdle getting grpc-swift to rebuild from Bitcode on watchOS. I've created #999 to track this issue. If you have any thoughts or suggestions on this, I would be immensely grateful.

@daltonclaybrook
Copy link
Contributor Author

@glbrntt good for another look

Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daltonclaybrook!

I just filed PRs for the various NIO components to make sure they also have watchOS deployment targets:

It looks like SwiftLog and SwiftProtobuf are already good to go. I'll wait for the above to be merged before merging this PR.

@glbrntt
Copy link
Collaborator

glbrntt commented Oct 19, 2020

have you actually tried gRPC on watchOS?

Yes! It works really well and I've been super pleased with it.

That's great to hear!

This was the crucial step for me to get it working. Though, it seems I may have one final hurdle getting grpc-swift to rebuild from Bitcode on watchOS. I've created #999 to track this issue. If you have any thoughts or suggestions on this, I would be immensely grateful.

I'm afraid not but it seems like you and @Lukasa have made progress on this.

@glbrntt glbrntt merged commit 7818989 into grpc:main Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants