Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Temporarily disable protoc-plugin in CI"" #1451

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Revert "Revert "Temporarily disable protoc-plugin in CI"" #1451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909d24c
Revert "Revert "Temporarily disable protoc-plugin in CI (#1447)" (#14…
sampajano Jun 25, 2024
2c9f750
Update run_basic_tests.sh
sampajano Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/run_basic_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ docker-compose down
echo -e "\n[Running] Basic test #3 - Testing everything buids"
if [[ "$MASTER" == "1" ]]; then
# Build all for continuous_integration
docker-compose build
# docker-compose build

# Temporary fix `protoc-plugin` build failure (introduced in
# https://github.com/grpc/grpc-web/pull/1445) by building
# everything but it.
# TODO: Revert to building all targets.
docker-compose build prereqs echo-server node-server node-interop-server envoy grpcwebproxy commonjs-client closure-client ts-client binary-client interop-client jsunit-test
else
# Only build a subset of docker images for presubmit runs
docker-compose build commonjs-client closure-client ts-client
Expand Down