Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a specific error on compressed frames #975

Closed
wants to merge 5 commits into from
Closed

Add a specific error on compressed frames #975

wants to merge 5 commits into from

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Oct 20, 2020

Instead of the generic 'invalid frame byte' a more specific error compressed frames aren't supported is returned when a compressed frame is received

Related to #561

Instead of the generic 'invalid frame byte'
@stanley-cheung
Copy link
Collaborator

@vbfox Sorry for the extreme delay. Just got around to run the tests and there was a syntax error

/github/grpc-web/packages/grpc-web/node_modules/.bin/google-closure-compiler --js=exports.js --js=../../javascript --js=../../third_party/closure-library --entry_point=grpc.web.Exports --externs=externs.js --dependency_mode=PRUNE --compilation_level=ADVANCED_OPTIMIZATIONS --generate_exports --export_local_property_definitions --js_output_file=index.js
../../javascript/net/grpc/web/grpcwebstreamparser.js:252: ERROR - [JSC_PARSE_ERROR] Parse error. '(' expected
const Parser = GrpcWebStreamParser;
      ^

1 error(s), 0 warning(s)
npm ERR! code ENOENT
npm ERR! syscall access
npm ERR! path /github/grpc-web/packages/grpc-web/node_modules/grpc-web.js
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, access '/github/grpc-web/packages/grpc-web/node_modules/grpc-web.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-12-05T01_20_58_770Z-debug.log
Service 'prereqs' failed to build: The command '/bin/sh -c cd ./packages/grpc-web &&   npm install &&   npm run build &&   npm link' returned a non-zero code: 254

Again my apologies for not getting to this.

@vbfox vbfox requested a review from stanley-cheung May 15, 2021 20:19
@vbfox
Copy link
Contributor Author

vbfox commented Mar 31, 2023

🤷🏼

@vbfox vbfox closed this Mar 31, 2023
@sampajano
Copy link
Collaborator

sampajano commented Mar 31, 2023

Apologies that these PRs slipped through the cracks during team transition.. If you think some of them are still valid and needed, please feel free to reopen.. sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants