Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR13599 and PR13655 to v1.8.x #13950

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Backport PR13599 and PR13655 to v1.8.x #13950

merged 2 commits into from
Jan 9, 2018

Conversation

y-zeng
Copy link
Contributor

@y-zeng y-zeng commented Jan 8, 2018 •
edited
Loading

#13934 should be merged first.

@y-zeng y-zeng requested a review from yang-g January 8, 2018 22:17
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +64  +0.0%

  [ = ]       0 TOTAL      +64  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] Performance differences noted:
Benchmark                                                                                          allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration    http2_pings_sent_per_iteration    locks_per_iteration    nows_per_iteration    writes_per_iteration
-------------------------------------------------------------------------------------------------  ----------------------  -----------------------  -----------------------  --------------------------------  ---------------------  --------------------  ----------------------
BM_PumpStreamClientToServer<MinTCP>/0                                                              -10%                    -4%                      -6%
BM_PumpStreamClientToServer<TCP>/0                                                                 -15%                    -7%                      -9%
BM_PumpStreamClientToServer<TCP>/1                                                                                         -4%                      -5%
BM_PumpStreamServerToClient<InProcessCHTTP2>/134217728                                                                                                                       -34%
BM_PumpStreamServerToClient<TCP>/134217728                                                                                                                                   -11%
BM_PumpStreamServerToClient<TCP>/512                                                                                                                                                                                                  +103%
BM_StreamingPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1                                                                         -6%                      -28%                              -4%                    -5%                   -5%
BM_StreamingPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2                                                                                                  -10%
BM_StreamingPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1                                                                      -6%                      -28%                                                     -6%                   -5%
BM_StreamingPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2                                                                                               -5%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/134217728/1                                                                                                           -33%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/1                                                                                                              -33%
BM_StreamingPingPongMsgs<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728                                                                       -6%                      -28%                              -5%                    -10%                  -5%
BM_StreamingPingPongMsgs<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728                                                                    -6%                      -28%                              -4%                    -6%                   -5%
BM_StreamingPingPongMsgs<MinTCP, NoOpMutator, NoOpMutator>/134217728                                                                                                         -25%
BM_StreamingPingPongMsgs<TCP, NoOpMutator, NoOpMutator>/134217728                                                                                                            -20%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/0                                                      -5%                      -31%                                                     -10%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/1                                                      -5%                      -31%                                                     -8%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/0                                                      -8%                      -30%                              -5%                    -7%                   -13%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/1                                                      -8%                      -30%                              -4%                    -5%                   -13%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/0                                                   -7%                      -37%                              -6%                    -17%                  -5%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/1                                                   -6%                      -33%                              -4%                    -12%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/0                                                   -8%                      -30%                              -4%                    -4%                   -13%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/1                                                   -8%                      -30%                              -5%                    -6%                   -13%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/0/134217728                                                                                                      -15%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/0                                                                             -6%                      -25%                              -4%                    -5%
BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/134217728                                                                     -6%                      -31%                              -4%                    -13%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/0/134217728                                                                                                   -14%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/0                                                                          -6%                      -25%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/134217728                                                                  -7%                      -34%                              -6%                    -16%                  -4%
BM_UnaryPingPong<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/16777216/16777216                                                                    -4%                                                                                                     -4%
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/134217728/0                                     -13%
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/134217728/134217728                                                                                                       -20%
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/134217728                                -54%                    -41%                     -38%                     -24%                              -39%

@y-zeng y-zeng changed the title Backport PR13655 to v1.8.x Backport PR13599 and PR13655 to v1.8.x Jan 9, 2018
@y-zeng y-zeng requested a review from kpayson64 January 9, 2018 00:46
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                                                                   FILE SIZE
 ++++++++++++++ GROWING                                                     ++++++++++++++
  +0.5%     +32 src/core/ext/transport/chttp2/transport/writing.cc              +32  +0.5%
      +0.6%     +34 grpc_chttp2_begin_write                                         +34  +0.6%
  +0.0%     +16 src/core/ext/transport/chttp2/transport/chttp2_transport.cc     +16  +0.0%
      +0.5%     +16 grpc_create_chttp2_transport                                    +16  +0.5%

 -+-+-+-+-+-+-+ MIXED                                                       +-+-+-+-+-+-+-
  +0.0%     +48 [None]                                                           -8  -0.0%

  +0.0%     +96 TOTAL                                                           +40  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] Performance differences noted:
Benchmark                                                                                          cpu_time    http2_pings_sent_per_iteration    real_time    writes_per_iteration
-------------------------------------------------------------------------------------------------  ----------  --------------------------------  -----------  ----------------------
BM_PumpStreamServerToClient<InProcessCHTTP2>/134217728                                                         -20%                                           -4%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/1                                 +5%                                           +5%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/1                                                -16%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/262144                            +6%                                           +6%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                             +4%                                           +4%
BM_StreamingPingPongMsgs<MinTCP, NoOpMutator, NoOpMutator>/134217728                                           -16%
BM_StreamingPingPongMsgs<TCP, NoOpMutator, NoOpMutator>/134217728                                              -16%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/0                 -10%                                           -9%
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/1                 -10%                                           -9%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/0           +4%                                           +4%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/0              -10%                                           -9%
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/2/1              -10%                                           -9%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/32768                               -5%                                           -5%

@y-zeng
Copy link
Contributor Author

y-zeng commented Jan 9, 2018

#13124, #13122. #13381

@y-zeng y-zeng merged commit 77ec6c9 into grpc:v1.8.x Jan 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kpayson64 kpayson64 kpayson64 approved these changes

@yang-g yang-g yang-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y-zeng @grpc-testing @yang-g @kpayson64