-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimal proxy package to route grpc to grpcio #21531
Conversation
Why not do the opposite (make [I'm assuming somehow you took over |
I agree with @mehrdada on this one. It would be great if no one had to use the word "grpcio" ever again. But @lidizheng has a point about Hyrum's law. It's possible that someone is explicitly depending on our current package name. I propose that we make I'll outline this in a gRFC so we can get community feedback on it. |
@lidizheng @gnossen I mean, a sure way to not disrupt the user is to never improve anything ever, so I don't really buy that argument :) I believe I think @gnossen's solution is excellent! If user is currently pinning to |
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
Yield to #23094 |
Adding a package that takes the same version of
grpcio
as dependency. It works as a proxy to install our official gRPC Python package. So, for people who typedgrpc
accidentally, now they should getgrpcio
installed properly.Let's see if our infra are happy first...