-
Notifications
You must be signed in to change notification settings - Fork 248
A85: Changes to xDS LRS Custom Metrics Support #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markdroth
merged 11 commits into
grpc:master
from
markdroth:xds_orca_lrs_propagation_fix
Nov 19, 2024
Merged
A85: Changes to xDS LRS Custom Metrics Support #454
markdroth
merged 11 commits into
grpc:master
from
markdroth:xds_orca_lrs_propagation_fix
Nov 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Sep 27, 2024
Implements gRFC A85 (grpc/proposal#454). Closes #37467 COPYBARA_INTEGRATE_REVIEW=#37467 from markdroth:orca_lrs_propagation_changes 0c1e889 PiperOrigin-RevId: 679646192
ejona86
approved these changes
Oct 4, 2024
dfawley
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few formatting suggestions but that's it.
Co-authored-by: Doug Fawley <dfawley@google.com>
Co-authored-by: Doug Fawley <dfawley@google.com>
Co-authored-by: Doug Fawley <dfawley@google.com>
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
Implements gRFC A85 (grpc/proposal#454). Closes grpc#37467 COPYBARA_INTEGRATE_REVIEW=grpc#37467 from markdroth:orca_lrs_propagation_changes 0c1e889 PiperOrigin-RevId: 679646192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.