A61 update: remove special case for LOGICAL_DNS clusters #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Mar 6, 2025
ejona86
approved these changes
Mar 6, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Note for posterity: it is safe to combine DNS results into a single endpoint because their attributes will be the same. Even with SRV records, since A26, DNS doesn't return the grpclb addresses mixed with the regular addresses.
dfawley
approved these changes
Mar 6, 2025
Member
Author
|
@murgatroid99 FYI. |
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Mar 11, 2025
…-coding pick_first (#38248) See grpc/proposal#477 for context. Closes #38248 COPYBARA_INTEGRATE_REVIEW=#38248 from markdroth:xds_logical_dns_all_addresses_in_one_endpoint 4cfa6ee PiperOrigin-RevId: 735820369
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Sep 15, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Sep 17, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Sep 18, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
ejona86
added a commit
to grpc/grpc-java
that referenced
this pull request
Sep 18, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Sep 26, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Sep 26, 2025
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.