fix: scanner breaks after constraint update #417
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanner does not work anymore after when `deviceId` via `constraints` is updated and no other props are changed. This is because: ==> both `cameraActive.value` and `cameraSettings.shouldStream` stay `true` ==> then `shouldScan` also does not change ==> therefore the watcher on `shouldScan` is not triggered ==> and finally we don't start a new scanning process To prevent that, we now explicitly set `cameraActive` to `false` right before requesting a new camera. That is not just a hack but also makes semantically sense, because the camera is briefly inactive right before requesting a new camera. See: #416
✅ Deploy Preview for vue-qrcode-reader ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
🎉 This PR is included in version 5.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanner does not work anymore after when
deviceIdviaconstraintsis updated and no other props are changed. This is because:==> both
cameraActive.valueandcameraSettings.shouldStreamstaytrue==> then
shouldScanalso does not change==> therefore the watcher on
shouldScanis not triggered==> and finally we don't start a new scanning process
To prevent that, we now explicitly set
cameraActivetofalseright before requesting a new camera. That is not just a hack but also makes semantically sense, because the camera is briefly inactive right before requesting a new camera.See: #416