Fix ghidra exporter script when structure field name is empty #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
- Coverage 8.63% 8.61% -0.02%
==========================================
Files 409 409
Lines 125568 125568
==========================================
- Hits 10842 10821 -21
- Misses 114726 114747 +21
☔ View full report in Codecov by Sentry. |
twevs
approved these changes
Sep 13, 2023
| @@ -15,6 +15,8 @@ | |||
| type_name = component.getDataType().getName() | |||
| print('type: ' + type_name) | |||
| field_name = component.getFieldName() | |||
| if field_name is None: | |||
| field_name = component.getDefaultFieldName() | |||
| print('field name: ' + field_name) | |||
There was a problem hiding this comment.
The proper python-y syntax would've been
print('field name: ' + field_name if field_name != None else component.getDefaultFieldName())but that's okay :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.