Skip to content

Conversation

@njfox
Copy link
Contributor

@njfox njfox commented Oct 24, 2025

The AUR CI workflow was failing due to new dependencies being added to the PKGBUILD but not the Github action. This PR adds the --syncdeps flag to automatically install any missing dependencies from the PKGBUILD when building the package.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Warning

Rate limit exceeded

@njfox has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 70fd877 and 98d1052.

📒 Files selected for processing (1)
  • .github/workflows/linux-aur.yml (1 hunks)

Walkthrough

The AUR build workflow step is updated to include -- --syncdeps flags when invoking makepkg as builduser, enabling automatic dependency synchronization during package builds.

Changes

Cohort / File(s) Summary
AUR Build Configuration
\.github/workflows/linux-aur.yml``
Modified makepkg invocation to add -- --syncdeps arguments when running as builduser, enabling dependency synchronization during AUR package builds

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/S

Suggested reviewers

  • nicolasnoble

Poem

🐰 A makepkg hops with faster feet,
With --syncdeps now so neat,
Dependencies sync without delay,
The AUR build saves the day! 📦

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "add --syncdeps to install missing PKGBUILD dependencies" is directly aligned with the primary change in the pull request. The changeset adds the --syncdeps flag to the makepkg command in the AUR CI workflow, and the title clearly and concisely describes this addition along with its purpose. The title is specific and informative without being vague or overly broad, accurately conveying the main modification to someone reviewing the commit history.
Description Check ✅ Passed The pull request description is clearly related to the changeset. It explains the underlying problem (AUR CI workflow failing due to missing dependencies) and describes the solution (adding the --syncdeps flag), which directly corresponds to the changes made in the workflow file. The description is not vague or generic; it provides meaningful context about both the issue being addressed and the specific fix being implemented.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@njfox njfox force-pushed the aur-ci-dependencies branch from 2af473c to 98d1052 Compare October 24, 2025 14:31
@njfox
Copy link
Contributor Author

njfox commented Oct 27, 2025

Note this AUR CI failure is expected as #1973 hasn't been merged yet to remove the deprecated fmt::localtime API:

 /usr/include/time.h:136:19: note:   ‘localtime’
src/gui/gui.cc:2425:61: error: ‘localtime’ is not a member of ‘fmt’
 2425 |                                                        fmt::localtime(version.timestamp)));
      |                                                             ^~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant