Bugfix/get server version gocd 19.5.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfbogdan
reviewed
Jul 11, 2019
tfbogdan
approved these changes
Jul 11, 2019
|
The tests haven't been touched in a long time, that shows. There will be a separate PR fixing the tests. |
|
#15 Should be merged first |
Include tfbogdan's sugestion Co-Authored-By: bogdan tudoran <tfbogdan@gmail.com>
madonius
force-pushed
the
bugfix/get-server-version-gocd-19.5.0
branch
from
0af423e
to
3736630
Compare
|
So what should we do about this merge request? |
|
I am still having trouble getting the tests to run, did not have too much time lately to look into it. The fix is functional, as far as I/we can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12