Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/test are not running #15

Merged
merged 9 commits into from
Aug 23, 2019

Conversation

madonius
Copy link
Collaborator

Fixes #14

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.016% when pulling 7e0aa22 on madonius:bugfix/test-are-not-running into 4c75336 on grundic:master.

@madonius
Copy link
Collaborator Author

@grundic can this be merged, or is something missing?

@tfbogdan
Copy link
Collaborator

tfbogdan commented Aug 1, 2019

Would be nice if we could get this and #13 merged. We're currently using a locally deployed version but that's a bit of a conundrum.

@tfbogdan
Copy link
Collaborator

@madonius, perhaps we should consider forking the project, to move things forward?

@grundic
Copy link
Owner

grundic commented Aug 23, 2019

Sorry, I'm not using this project anymore. Looks good to me.

@grundic grundic merged commit bcf95b5 into grundic:master Aug 23, 2019
@tfbogdan
Copy link
Collaborator

@grundic, no need to be sorry. It's your time.

Would you be ok with giving away ownership to the project if you have no interest in using it anymore?

@grundic
Copy link
Owner

grundic commented Aug 23, 2019

Yes, this is an option. Shall you be a new owner or @madonius?

@madonius
Copy link
Collaborator Author

@grundic I would speak with my organisation about the ownership and will get back. Meanwhile, I am trying to fix the issues with 19.5.0 and the tests.

@tfbogdan
Copy link
Collaborator

I'm not really sure how this works. Maybe changing ownership is not necessary as long as you give someone else push access. You could give us both push access for a start then. Unless you want to get rid of the project altogether case in which I can assume its ownership at least temporarily until someone expresses an interest in it.

@grundic
Copy link
Owner

grundic commented Sep 11, 2019

SGTM! Sent invitation to both for collaboration.

@david-m-m
Copy link

@madonius will be back next week. So please be patient for another couple of days.
BTW: We decided that we can offer to provide maintainership for this project for the time being. (Although a couple of details still need to be sorted out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test are failing
5 participants