Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to coffeescript 2 #196

Merged
merged 7 commits into from
Oct 31, 2017
Merged

Conversation

davidhennemann
Copy link
Contributor

I updated grunt-contrib-coffee to use coffeescript 2. Changed the version number to 2, because otherwise npm update would break existing applications using this plugin.

@jsf-clabot
Copy link

jsf-clabot commented Sep 27, 2017

CLA assistant check
All committers have signed the CLA.

@davidhennemann
Copy link
Contributor Author

I think the test runner broke?

@stuikomma
Copy link

The test fails with:

/home/travis/build/gruntjs/grunt-contrib-coffee/node_modules/coffeescript/lib/coffeescript/index.js:46
  CoffeeScript.run = function(code, options = {}) {
                                            ^
>> Got an unexpected exception from the coffee-script compiler. The original exception was: SyntaxError: Unexpected token =
>> (The coffee-script compiler should not raise unexpected exceptions. You can file this error as an issue of the coffee-script compiler: https://github.com/jashkenas/coffee-script/issues)

I think the error is in the node version. This test ran with version v0.10.48. http://coffeescript.org/#compatibility lists node 7.6+ as a requirement. So it does not make sense to run the tests with an older version of node.

You need to remove older versions from appveyor.yml and .travis.yml. Probably you should first pull the latest https://github.com/gruntjs/grunt-contrib-internal and then make the customizations necessary.

@bergie bergie mentioned this pull request Oct 2, 2017
6 tasks
@Mte90
Copy link

Mte90 commented Oct 5, 2017

any hope for a merge of this one?

@Mte90
Copy link

Mte90 commented Oct 9, 2017

Seems that I am not the only one waiting a lot this pull request approval.

@bergie
Copy link

bergie commented Oct 14, 2017

Would be great to get this merged and released, as then users (like NoFlo) could update seamlessly to CoffeeScript 2. I'm not sure who is the maintainer of the module. Seems latest activity was by @vladikoff

@Mte90
Copy link

Mte90 commented Oct 18, 2017

It is blocking too many project :-/

@vladikoff
Copy link
Member

vladikoff commented Oct 18, 2017 via email

@Mte90
Copy link

Mte90 commented Oct 30, 2017

any updates for this one? I know that I am annoying but is important :-D

@vladikoff vladikoff merged commit f9eec6e into gruntjs:master Oct 31, 2017
@vladikoff
Copy link
Member

2.0.0 on npm! please let us know if there are any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants