Switch to GitHub Actions CI. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
gh-actions
branch
2 times, most recently
from
a89bc93
to
4e1ada9
Compare
|
This looks exciting!! |
XhmikosR
force-pushed
the
gh-actions
branch
from
4e1ada9
to
594f863
Compare
|
So, how do you want to proceed with this? We should probably make this another major version bump and in the projects we update to the new version we'd need to remove Travis CI and AppVeyor from hooks and/or integrations. |
|
Maybe wait until actions/setup-node#27 is fixed? |
XhmikosR
force-pushed
the
gh-actions
branch
2 times, most recently
from
96d2b1c
to
6bd64ac
Compare
|
@XhmikosR do we still need an upstream fix for node 8? |
|
Not sure, I'll try again tomorrow. |
XhmikosR
force-pushed
the
gh-actions
branch
2 times, most recently
from
1566ecc
to
ec0abe0
Compare
|
@vladikoff PR updated. I didn't add caching because I'd rather err on the safe side. Do note that if we merge this it should be a major version bump. |
vladikoff
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Fixes #42
/CC @vladikoff for thoughts