Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump puppeteer dependency #291

Closed
wants to merge 1 commit into from
Closed

Bump puppeteer dependency #291

wants to merge 1 commit into from

Conversation

cburgmer
Copy link

@cburgmer cburgmer commented Dec 1, 2018

Puppeteer fixes an issues for me in 1.11.0.

Was there's a reason why puppeteer is fixed to a certain version? This change uses npm's default ^ version range.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@cburgmer
Copy link
Author

cburgmer commented Dec 1, 2018

For this trivial change I'm sure I won't need to sign a CLA.

@cburgmer cburgmer mentioned this pull request Dec 1, 2018
Closed
@steveoh
Copy link
Contributor

steveoh commented Jan 3, 2019

I think CLA's are required no matter what but maybe @vladikoff can verify.

@steveoh steveoh closed this in 0981f03 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cburgmer @jsf-clabot @steveoh