-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for sandboxArgs; passing options to puppeteer #319
Conversation
Matthew Edwards seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
I don't know enough about this to offer an opinion or a useful review. Thanks @vladikoff for offering a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me other than bumping the version in the package.json
@steveoh would you prefer it be a patch. My thoughts were that it's a feature add, so bump minor. |
I think @vladikoff's deploy pipeline handles that. |
Removed bump to version in |
Did you sign the CLA @wondersloth? |
Yes, I did sign it with my personal email address, though the commit is with my work email address. I've also per the instructions added that work email address to my github account. |
@steveoh Do you recommend I discard, this PR and create a new one and see if that trips the action again? |
Changed my commit locally to my personal email and updated the PR to see if that passes the CLA check. |
I'll defer to @vladikoff on that one. |
@vladikoff It appears that the CLA check has passed now. |
Hi @vladikoff just following up if there's anything I need to do, or if there's anything you want before approving this PR. Understandable if you're busy, just wanted to follow up. Thanks. |
@wondersloth yea this is in inbox to look at, will get to it in the next few days. Last time i glanced the PR looked great 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would probably revert the changelog and then revert all the markdown changes other than the new ones you are adding unless there is reason to modify those.
Fixes #307
Submitting this PR for the sandboxArgs feature. In my use case I need to use a different version of chrome then what's provided with Puppeteer.
I use this to leverage the
executeablePath
argument.