Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures errors in stdoutEqual callback are logged #275

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

raddevon
Copy link
Contributor

@raddevon raddevon commented Nov 9, 2017

Since stdout is redirected while the callback is executed, any errors the callback throws are suppressed and never logged. This unhooks process.stdout.write after catching an error in callback() and re-throws it so it will be logged.

Since stdout is redirected while the callback is executed, any errors the callback throws are suppressed and never logged. This unhooks `process.stdout.write` after catching an error in `callback()` and re-throws it so it will be logged.
@jsf-clabot
Copy link

jsf-clabot commented Nov 9, 2017

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants