Update uglify

[XhmikosR]

/CC @ @alexlamsl: are there any breaking changes in 2.8.0 we should take care of? So far I see Windows builds fail due to WARN: Output exceeds 40 characters.

[alexlamsl]

@XhmikosR that warning is new but harmless - it merely states the fact that the despite specifying output = {max_line_len: 40} it was unable to quite fit the line into that stated limit.

I guess a test in this project has set that specifically.

[XhmikosR]

I'll see how to work around this then.

Are there any breaking changes though?

[alexlamsl]

global_defs now applies to globally declared variables - but this option does nothing by default.

Not sure if these counts as well, but collapse_vars and reduce_vars are now enabled by default.

[XhmikosR]

OK, thanks. Those shouldn't affect us.

[alexlamsl]

@XhmikosR please consider applying the one-liner from mishoo/UglifyJS#1516 (comment)

[XhmikosR]

@alexlamsl; you mean in this branch? Note that I have no idea why they say there they get 2.8.0 since we use a tilde for uglify so it shouldn't get that.

[alexlamsl]

@XhmikosR I mumbled about that in mishoo/UglifyJS#1519 (comment) as well.

Anyway, this new method is introduced back in uglify-js 2.6.3, and without it passes (& now reduce_vars) cannot be used, i.e. they will be no-op.

[XhmikosR]

@alexlamsl: so I apply that one line patch and I get different output. Is that normal?

I pushed the patches in this branch for you to have a quick look.

[alexlamsl]

@XhmikosR the minified .js looks correct to me (I don't have enough knowledge on source maps)

Thanks!

[XhmikosR]

I'm gonna merge this and release the new version in a few hours.

[kzc]

2.8.3 will be released shortly:

mishoo/UglifyJS#1523

[XhmikosR]

@kzc: although it shouldn't matter due to us using tilde for uglify version, I can wait for 2.8.3, rebase and then release the new version.

[kzc]

@XhmikosR True, but that uglify-js@2.8.2 error is fairly likely to occur in the wild.

[alexlamsl]

uglify-js 2.8.3 released.