Update dependencies and testing workflow #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Jan 29, 2023
| "findup-sync": "~0.3.0", | ||
| "glob": "~7.1.6", | ||
| "findup-sync": "~5.0.0", | ||
| "glob": "~8.1.0", |
There was a problem hiding this comment.
@vladikoff just FYI this bump could wreak havoc for Windows users since backslashes need to be escaped in v8.x.
newhouse
reviewed
Jan 30, 2023
| @@ -7,7 +7,7 @@ | |||
| "repository": "https://github.com/gruntjs/grunt.git", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": ">=8" | |||
| "node": ">=16" | |||
There was a problem hiding this comment.
FYI: I think that if you're following Semver, this is a breaking change, requiring a major version bump. Yet this was published in a minor version bump (1.5.X => 1.6.0).
This means that packages (like spectaql) that had something like this in their dependencies will now break for installations on Node < 16:
{
...
"dependencies": {
...
"grunt": "^1.5.3",
...
}
...
}UPDATE: already noticed in #1751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.