Add video to production framework #449

brikis98 · 2022-08-01T14:22:37Z

The video for my talk Cloud Adoption Fails: 5 Ways Deployments Go Wrong and 5 Solutions is now available. Since this talk introduces the Gruntwork Production Framework, I'm embedding the video in the guide.

Direct link to relevant page in preview env: https://deploy-preview-449--pensive-meitner-faaeee.netlify.app/guides/production-framework/

netlify · 2022-08-01T14:23:07Z

✅ Deploy Preview for pensive-meitner-faaeee ready!

Name	Link
🔨 Latest commit	`528f367`
🔍 Latest deploy log	https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/62e7e1afa43bb700089828a4
😎 Deploy Preview	https://deploy-preview-449--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-08-01T14:24:46Z

✅ Deploy Preview for pensive-meitner-faaeee ready!

Name	Link
🔨 Latest commit	`bd405ac`
🔍 Latest deploy log	https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/62e94f93cf134f00083307e4
😎 Deploy Preview	https://deploy-preview-449--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brikis98 · 2022-08-01T14:56:38Z

How come the Netlify preview didn't seem to update after my latest commit?

brikis98 · 2022-08-01T14:57:22Z

Ah, whoops, I think I updated the wrong file 🤦

brikis98 · 2022-08-01T15:03:31Z

Hm, or not... The preview still seems to be showing the first commit?

brikis98 · 2022-08-01T15:04:01Z

@eak12913 @oredavids What am I missing?

rhoboat

LGTM!

brikis98 · 2022-08-02T14:52:39Z

For clarity: the preview URL shows the video, but it isn’t 100% width and the text above it isn’t up to date… I added the video in one commit, then did the 100% width & text changes in subsequent commits, but the preview only shows the first commit.

Video should be wider

rhoboat · 2022-08-02T15:49:03Z

Going to try kicking off the job again. I think we recreated the mistakenly deleted client-gruntwork team.

yorinasub17 · 2022-08-02T16:09:04Z

For clarity: the preview URL shows the video, but it isn’t 100% width and the text above it isn’t up to date… I added the video in one commit, then did the 100% width & text changes in subsequent commits, but the preview only shows the first commit.

Looks like you introduced an error in this commit. From the netlify build log:

10:01:06 AM: [ERROR] Docusaurus Node/SSR could not render static page with path /guides/production-framework/ because of following error:
10:01:06 AM: Error: Minified React error #62; visit https://reactjs.org/docs/error-decoder.html?invariant=62 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
10:01:06 AM:     at a.b.renderDOM (main:86857:354)
10:01:06 AM:     at a.b.render (main:86852:399)
10:01:06 AM:     at a.b.read (main:86851:83)
10:01:06 AM:     at Object.exports.renderToString (main:86862:138)
10:01:06 AM:     at doRender (main:22891:356)
10:01:06 AM:     at async serverEntry_render (main:22887:284)
10:01:10 AM: [success] [webpackbar] Server: Compiled with some errors in 16.85s
10:01:10 AM: Error: Server-side rendering fails due to the error above.
10:01:10 AM: [ERROR] Unable to build website for locale en.
10:01:10 AM: [ERROR] Error: Failed to compile with errors.
10:01:10 AM:     at /opt/build/repo/node_modules/@docusaurus/core/lib/webpack/utils.js:202:24
10:01:10 AM:     at /opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:554:14
10:01:10 AM:     at processQueueWorker (/opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:491:6)
10:01:10 AM:     at processTicksAndRejections (node:internal/process/task_queues:78:11)
10:01:10 AM: error Command failed with exit code 1. (https://ntl.fyi/exit-code-1)

And the actual error message:

The style prop expects a mapping from style properties to values, not a string. For example, style={{marginRight: spacing + 'em'}} when using JSX.

brikis98 · 2022-08-02T16:22:12Z

For clarity: the preview URL shows the video, but it isn’t 100% width and the text above it isn’t up to date… I added the video in one commit, then did the 100% width & text changes in subsequent commits, but the preview only shows the first commit.

Looks like you introduced an error in this commit. From the netlify build log:

10:01:06 AM: [ERROR] Docusaurus Node/SSR could not render static page with path /guides/production-framework/ because of following error:
10:01:06 AM: Error: Minified React error #62; visit https://reactjs.org/docs/error-decoder.html?invariant=62 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
10:01:06 AM:     at a.b.renderDOM (main:86857:354)
10:01:06 AM:     at a.b.render (main:86852:399)
10:01:06 AM:     at a.b.read (main:86851:83)
10:01:06 AM:     at Object.exports.renderToString (main:86862:138)
10:01:06 AM:     at doRender (main:22891:356)
10:01:06 AM:     at async serverEntry_render (main:22887:284)
10:01:10 AM: [success] [webpackbar] Server: Compiled with some errors in 16.85s
10:01:10 AM: Error: Server-side rendering fails due to the error above.
10:01:10 AM: [ERROR] Unable to build website for locale en.
10:01:10 AM: [ERROR] Error: Failed to compile with errors.
10:01:10 AM:     at /opt/build/repo/node_modules/@docusaurus/core/lib/webpack/utils.js:202:24
10:01:10 AM:     at /opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:554:14
10:01:10 AM:     at processQueueWorker (/opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:491:6)
10:01:10 AM:     at processTicksAndRejections (node:internal/process/task_queues:78:11)
10:01:10 AM: error Command failed with exit code 1. (https://ntl.fyi/exit-code-1)

And the actual error message:

The style prop expects a mapping from style properties to values, not a string. For example, style={{marginRight: spacing + 'em'}} when using JSX.

Ohhh, man, I totally missed that. I tried browsing the logs, but I think I was still seeing the logs from the old preview env and not the new (broken) one 🤦

Thanks for the pointer!

brikis98 · 2022-08-02T16:26:16Z

OK, I had to use JSX syntax, and now things are working. Thanks for the eagle eyes @yorinasub17!

I need one more "ship it" and this is good to go!

yorinasub17

LGTM!

rhoboat · 2022-08-02T16:47:35Z

@yorinasub17 Where did you see the "actual error message"? I clicked into the Deploy Log on netlify's console, and just saw the stuff you posted in the scrolling code block, but not the actual error message.

rhoboat

LGTM!

yorinasub17 · 2022-08-02T17:18:22Z

Where did you see the "actual error message"?

It's in the link in the error message in the deploy logs.

rhoboat · 2022-08-02T17:24:45Z

Oh, this link. It's a generic error message: https://reactjs.org/docs/error-decoder.html?invariant=62 😮‍💨

brikis98 · 2022-08-03T10:11:23Z

Thank you for the review! Merging and releasing now.

Add video to production framework

528f367

brikis98 requested review from oredavids, ebeneliason, eak12913 and pete0emerson as code owners August 1, 2022 14:22

Updated _docs-sources with this contribution and regenerated output.

bbc0384

Make video 100% width

caa238b

brikis98 and others added 2 commits August 1, 2022 15:57

Update embed code in proper MD file

ec5dfba

Updated _docs-sources with this contribution and regenerated output.

ff0c827

brikis98 and others added 2 commits August 1, 2022 15:59

Update wording

66d1a01

Updated _docs-sources with this contribution and regenerated output.

8fbacc4

rhoboat previously approved these changes Aug 2, 2022

View reviewed changes

brikis98 and others added 2 commits August 2, 2022 17:23

Switch style to JSX syntax

b279dfa

Updated _docs-sources with this contribution and regenerated output.

bd405ac

yorinasub17 approved these changes Aug 2, 2022

View reviewed changes

rhoboat approved these changes Aug 2, 2022

View reviewed changes

brikis98 merged commit 368b10e into master Aug 3, 2022

brikis98 deleted the brikis98-patch-1 branch August 3, 2022 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add video to production framework #449

Add video to production framework #449

brikis98 commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022 •

edited

Loading

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

rhoboat left a comment

brikis98 commented Aug 2, 2022

rhoboat commented Aug 2, 2022 •

edited

Loading

yorinasub17 commented Aug 2, 2022 •

edited

Loading

brikis98 commented Aug 2, 2022

brikis98 commented Aug 2, 2022

yorinasub17 left a comment

rhoboat commented Aug 2, 2022 •

edited

Loading

rhoboat left a comment

yorinasub17 commented Aug 2, 2022

rhoboat commented Aug 2, 2022 •

edited

Loading

brikis98 commented Aug 3, 2022

Add video to production framework #449

Add video to production framework #449

Conversation

brikis98 commented Aug 1, 2022 • edited Loading

netlify bot commented Aug 1, 2022 • edited Loading

✅ Deploy Preview for pensive-meitner-faaeee ready!

netlify bot commented Aug 1, 2022 • edited Loading

✅ Deploy Preview for pensive-meitner-faaeee ready!

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

brikis98 commented Aug 1, 2022

rhoboat left a comment

Choose a reason for hiding this comment

brikis98 commented Aug 2, 2022

rhoboat commented Aug 2, 2022 • edited Loading

yorinasub17 commented Aug 2, 2022 • edited Loading

brikis98 commented Aug 2, 2022

brikis98 commented Aug 2, 2022

yorinasub17 left a comment

Choose a reason for hiding this comment

rhoboat commented Aug 2, 2022 • edited Loading

rhoboat left a comment

Choose a reason for hiding this comment

yorinasub17 commented Aug 2, 2022

rhoboat commented Aug 2, 2022 • edited Loading

brikis98 commented Aug 3, 2022

brikis98 commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022 •

edited

Loading

rhoboat commented Aug 2, 2022 •

edited

Loading

yorinasub17 commented Aug 2, 2022 •

edited

Loading

rhoboat commented Aug 2, 2022 •

edited

Loading

rhoboat commented Aug 2, 2022 •

edited

Loading