Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APT-1570] [APT-1572] [APT-1555] [APT-1581] Bootstrapping nav and layout #57

Merged
merged 7 commits into from
Nov 24, 2021

Conversation

ebeneliason
Copy link
Contributor

This PR includes work across several of my stories. I've broken it down into logical chunks by commit, so I recommend reviewing one commit at a time to make sense of each change. That said, I felt that seeing it all together in the preview was more useful than viewing piecewise, hence the single PR.

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: 29d7a5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/619e8a6cb0029a0007030303

😎 Browse the preview: https://deploy-preview-57--pensive-meitner-faaeee.netlify.app

@eak12913
Copy link
Contributor

Should we consider having the "light" background be the same as in Aperture?
image

ie - not white but just slightly off-white?

@eak12913
Copy link
Contributor

From Ore:
image
There appears to be some extra spacing after the last item in the sublist..do we want to keep the left border line when there's empty space like that? It may make it seem like something is supposed to be there but not rendering.

@@ -46,10 +51,11 @@ const config = {
/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
({
navbar: {
title: "Gruntwork Docs",
title: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting rid of the title?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh perhaps it's logo now that's entirely an image?

@@ -7,39 +7,41 @@
/* You can override the default Infima variables here. */
:root {
/* default */
--ifm-color-primary: #25c2a0;
/* --ifm-color-primary: #25c2a0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this?

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for merge. We agreed to clean up any loose ends as we make further progress.

@ebeneliason ebeneliason merged commit 34031ab into master Nov 24, 2021
@ebeneliason ebeneliason deleted the bootstrapping-nav-and-layout branch November 24, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants