Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency reference #44

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

DorfilIkatu
Copy link
Contributor

github.com/codegangsta/cli has moved to gopkg.in/urfave/cli.v1. Github is automatically redirecting requests to codegangsta, but it is recommended to update the references.

@brikis98
Copy link
Member

LGTM, thx! How did you test this change?

@DorfilIkatu
Copy link
Contributor Author

I'm adding the fetch tool to a SDK using Yocto. I was already able to build fetch and it's dependencies. But I realize I was having two dependencies that had exactly the same source code (github.com/codegangsta/cli and gopkg.in/urfave/cli.v1).
What happened was that fetch imports github.com/codegangsta/cli which is redirected to gopkg.in/urfave/cli.v1, and gopkg.in/urfave/cli.v1 was importing itself (https://github.com/urfave/cli/blob/934abfb2f102315b5794e15ebc7949e4ca253920/altsrc/flag.go#L9), so I ended up with the both dependencies.
After making the change, fetch tool stills builds correctly and I can use it with no problems in my SDK.

@brikis98
Copy link
Member

OK, great, thanks. I'll merge and let the tests run. If they pass, I'll create a new release and paste the link.

@brikis98 brikis98 merged commit 48ae79f into gruntwork-io:master Oct 12, 2018
@brikis98
Copy link
Member

@DorfilIkatu DorfilIkatu deleted the update-gangsta-reference branch October 13, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants