Add utilities for autoscaling. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
reviewed
Sep 26, 2022
Comment on lines
+53
to
+54
| logger.Errorf("Failed to set ASG desired capacity to %d", desiredCapacity) | ||
| logger.Errorf("If the capacity is set in AWS, undo by lowering back to the original desired capacity. If the desired capacity is not yet set, triage the error message below and try again.") |
There was a problem hiding this comment.
NIT: these are kind of application specific logs. I would probably convert these to a custom error type that the caller can use to decide what log message to output.
This approach would also help with removing the need to handle a logger in these funcs.
There was a problem hiding this comment.
I will take care of this remaining issue in a future PR. I resolved the others, because they should be fixed by #73
yorinasub17
approved these changes
Sep 26, 2022
|
Going to merge this up and address comments in a future PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utility functions for autoscaling.
Documentation
TODOs
Related Issues
Relates to https://github.com/gruntwork-io/ecsgrunt/pull/2.