Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for explicitly setting lifecycle hooks #120

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add support for explicitly setting lifecycle hooks #120

merged 1 commit into from
Jan 10, 2022

Conversation

yorinasub17
Copy link
Contributor

Description

This adds the ability to configure a custom lifecycle hook on the main application container, in a way that works nicely with the existing shutdownDelay input value.

TODOs

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backwards compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.

autero1
autero1 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@autero1 autero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit 6e832c5 into master Jan 10, 2022
@yorinasub17 yorinasub17 deleted the feature/expose-lifecycle branch January 10, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autero1 autero1 autero1 approved these changes

@bwhaley bwhaley Awaiting requested review from bwhaley

@rhoboat rhoboat Awaiting requested review from rhoboat

@zackproser zackproser Awaiting requested review from zackproser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorinasub17 @autero1