Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress port number type conversion issue #126

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

yorinasub17
Copy link
Contributor

Description

This PR fixes a bug where the number type checking for ingress port expression isn't good enough when passing through a number with values.yaml. helm seems to coerce numbers into strings when going through a values.yaml file, which doesn't happen when using --set.

This PR also adds a regression test to make sure we test the path with values.yaml.

Additional note

The regression test expectedly fails without the fix in adc8373 (see build https://app.circleci.com/pipelines/github/gruntwork-io/helm-kubernetes-services/343/workflows/8e969b8a-2c9e-4b1f-819d-e15fb52ff958), but passes after the fix (see https://app.circleci.com/pipelines/github/gruntwork-io/helm-kubernetes-services/344/workflows/a0eeb12e-f372-4005-894b-0e54d3843364)

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.

Copy link
Contributor

@autero1 autero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit a3662ea into master Feb 9, 2022
@yorinasub17 yorinasub17 deleted the bug/type-conversion-issue branch February 9, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants