Ingress port number type conversion issue #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the number type checking for ingress port expression isn't good enough when passing through a number with
values.yaml
.helm
seems to coerce numbers into strings when going through avalues.yaml
file, which doesn't happen when using--set
.This PR also adds a regression test to make sure we test the path with
values.yaml
.Additional note
The regression test expectedly fails without the fix in adc8373 (see build https://app.circleci.com/pipelines/github/gruntwork-io/helm-kubernetes-services/343/workflows/8e969b8a-2c9e-4b1f-819d-e15fb52ff958), but passes after the fix (see https://app.circleci.com/pipelines/github/gruntwork-io/helm-kubernetes-services/344/workflows/a0eeb12e-f372-4005-894b-0e54d3843364)
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955
orbug/missing-count-param-434
.