Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom args on deployment spec #143

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

thiagosalvatore
Copy link
Contributor

@thiagosalvatore thiagosalvatore commented Aug 10, 2022

Description

Enables support for custom args on deployment spec. The current helm only allows custom commands, making it hard to reuse the image by changing the args only and keeping the command (ENTRYPOINT).
It is supported by Kubernetes, for reference: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#use-environment-variables-to-define-arguments.

Gist with template tests

Implements #142

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

[X] - Added new input parameter containerArgs that can be used to define custom args that should be passed to the deployment spec. It behaves exactly as the containerCommand, the only difference is that it will populate the args instead of the command in the spec.

@autero1
Copy link
Contributor

autero1 commented Aug 12, 2022

Thanks for the PR @thiagosalvatore !
The change LGTM, running the tests now.

@autero1 autero1 merged commit 67a53e5 into gruntwork-io:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants