Allow custom args on deployment spec #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables support for custom args on deployment spec. The current helm only allows custom commands, making it hard to reuse the image by changing the args only and keeping the command (ENTRYPOINT).
It is supported by Kubernetes, for reference: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#use-environment-variables-to-define-arguments.
Gist with template tests
Implements #142
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
[X] - Added new input parameter
containerArgs
that can be used to define custom args that should be passed to the deployment spec. It behaves exactly as thecontainerCommand
, the only difference is that it will populate theargs
instead of thecommand
in the spec.