Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose traffic policy configuration for service #148

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Expose traffic policy configuration for service #148

merged 3 commits into from
Oct 18, 2022

Conversation

denis256
Copy link
Member

Description

Update k8s-service helm chart to allow configuration of traffic policies for created K8S service

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

autero1
autero1 reviewed Oct 16, 2022
View reviewed changes
Copy link
Contributor

@autero1 autero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just a minor note about documenting the new config options. As the potential fix won't affect tests, I'll kick off those now!

charts/k8s-service/values.yaml Show resolved Hide resolved
autero1
autero1 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@autero1 autero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Merging this in now.

@autero1 autero1 merged commit 134eb6b into gruntwork-io:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autero1 autero1 autero1 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis256 @autero1