Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version compatibility to the HPA API for k8s >= 1.23 #151

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Add version compatibility to the HPA API for k8s >= 1.23 #151

merged 8 commits into from
Jan 24, 2023

Conversation

autero1
Copy link
Contributor

@autero1 autero1 commented Jan 20, 2023

Description

Fixes #145 and #146

  • Use autoscaling/v2 API in HPA for Kubernetes versions >= 1.23.
  • Test with Kubernetes 1.21 and 1.24 (drop 1.17)
  • Upgrade to Go 1.18

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Use autoscaling/v2 API in HPA for Kubernetes versions >= 1.23.

@autero1 autero1 requested a review from zackproser as a code owner January 20, 2023 20:27
zackproser
zackproser approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@autero1 autero1 merged commit 8dd41b9 into main Jan 24, 2023
@autero1 autero1 deleted the chore/update-versions branch January 24, 2023 15:35
@paul-pop paul-pop mentioned this pull request Jan 24, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

@ryehowell ryehowell Awaiting requested review from ryehowell ryehowell is a code owner

@pras111gw pras111gw Awaiting requested review from pras111gw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing HPA capability for Kubernetes 1.23
2 participants
@autero1 @zackproser