Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git improvements #19

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Git improvements #19

merged 3 commits into from
Aug 23, 2023

Conversation

marinalimeira
Copy link
Contributor

  • Fix branch name to match the old one.
  • Set remote with token before git push

branch += "-updates"

if (dependency) {
branch += `-${dependency}`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(question, non-blocking): When we have dependency here - What would be a final example of an going branch name for updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a folder also: pathcher-dev-updates-gruntwork-io/terraform-aws-vpc/vpc-app.

Without a folder: pathcher-updates-gruntwork-io/terraform-aws-vpc/vpc-app.

I will add this as a comment!

src/action.ts Show resolved Hide resolved
cvbarros
cvbarros previously approved these changes Aug 23, 2023
@marinalimeira
Copy link
Contributor Author

Thanks for re-approving!

@marinalimeira marinalimeira merged commit 4b6f915 into main Aug 23, 2023
@marinalimeira marinalimeira deleted the update-git-push branch August 23, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants