Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI with GH Actions #28

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Setup CI with GH Actions #28

merged 9 commits into from
Sep 7, 2023

Conversation

marinalimeira
Copy link
Contributor

@marinalimeira marinalimeira commented Sep 6, 2023

Jira: PATCHER-302

  • Test validation with yarn test
  • Add check to the dist/ folder, the versioned one should always be up-to-date.
  • Configure ESLint and add it to the CI checks.

steps:
- uses: actions/checkout@v3
- name: Setup Node.js
uses: actions/setup-node@v3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This download is cached, in the logs it's possible to see the Found in cache @ /opt/hostedtoolcache/node/18.17.1/x64 when installing node.

Copy link

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marinalimeira
Copy link
Contributor Author

Thanks for reviewing!!

@marinalimeira marinalimeira merged commit c45c739 into main Sep 7, 2023
@marinalimeira marinalimeira deleted the setup-yarn-ci branch September 7, 2023 13:52
node-version: '18'
- name: Install dependencies
run: yarn
- name: Run tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Run lint"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants