Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download patching tools #29

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Download patching tools #29

merged 4 commits into from
Sep 8, 2023

Conversation

marinalimeira
Copy link
Contributor

Jira: PATCHER-308

  • Downloading the tools necessary to run terrapatch.
  • Updated function that was downloading patcher binary to download any binary from GitHub. Now these binaries will also be available in the PATH.

Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not close enough to the code to fully understand this, but it looks functional to me. If there's an easy way to test this, then I'd propose writing up some instructions next time.

@marinalimeira
Copy link
Contributor Author

LGTM. I'm not close enough to the code to fully understand this, but it looks functional to me. If there's an easy way to test this, then I'd propose writing up some instructions next time.

To test locally is necessary to have act installed. I run this command:

yarn build && act -W .github/workflows/test.yml -s GITHUB_TOKEN=$GITHUB_OAUTH_TOKEN --container-architecture linux/amd64

@marinalimeira
Copy link
Contributor Author

Thanks for reviewing! I will merge it to start testing today with the dogfood repos.

@marinalimeira marinalimeira merged commit 204e883 into main Sep 8, 2023
@marinalimeira marinalimeira deleted the download-patch-tools branch September 8, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants