Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over namespace modules from terraform-kubernetes-helm #1

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

yorinasub17
Copy link
Contributor

This ports over the namespace modules from terraform-kubernetes-helm to this new repo. The modules have also been renamed to drop redundancy:

  • k8s-namespace => namespace
  • k8s-namespace-roles => namespace-roles
  • k8s-service-account => service-account

The following changes were also introduced as a part of this porting:

  • The modules now work with terraform 0.13.x.
  • Resource rename: rbac_tiller_metadata_access_role => rbac_helm_metadata_access_role
  • Resource rename: rbac_tiller_resource_access_role => rbac_helm_resource_access_role

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume most of this code is moved as-is from the original repo, so I didn't do too deep of a review, but from a quick scan of the new stuff, this LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for the review! Going to merge this now since the tests are passing and will draft the release notes + migration guide.

@yorinasub17 yorinasub17 merged commit 1ce47c4 into main Dec 15, 2020
@yorinasub17 yorinasub17 deleted the yori-initial branch December 15, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants