Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use a custom registry #74

Open
hpedrorodrigues opened this issue Jul 16, 2024 · 2 comments
Open

Add support to use a custom registry #74

hpedrorodrigues opened this issue Jul 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hpedrorodrigues
Copy link

hpedrorodrigues commented Jul 16, 2024

Hey 👋🏻

First of all, thanks for maintaining this action! 🚀

Describe the problem you are experiencing

Docker Hub started enforcing rate limits to Google IP addresses on July 15, 2024. So, anyone using this action along with self-hosted runners in Google Cloud may eventually hit the pull limit.

e.g.,

toomanyrequests: You have reached your pull rate limit.

Describe the solution you'd like

One of the options given by Google Cloud is to create a remote repository. However, to use this action along with a remote repository, we will need a way to provide a custom registry.

e.g., gruntwork/terragrunt -> <location>.pkg.dev/<project>/<repository>/gruntwork/terragrunt

Additional context


Not sure if I'm missing something here. So please let me know.

@hpedrorodrigues hpedrorodrigues added the enhancement New feature or request label Jul 16, 2024
@hpedrorodrigues hpedrorodrigues changed the title Add support to use a different image Add support to use a custom registry Jul 16, 2024
@hpedrorodrigues
Copy link
Author

AFAIK, GitHub doesn't allow setting build args to docker container actions (e.g., actions/runner#2019). So, in the meantime, I decided to create this one (tf-check) since I only use this action to check file formats at the moment.

If you see another option besides publishing this image to another registry, I'm open to working on it.

Let me know your thoughts.

@marcinkubica
Copy link

marcinkubica commented Sep 6, 2024

@hpedrorodrigues or you could publish the image to ghcr.io and the problem is "solved". I'm doing it myself in a private repo. But it's so ugly to maintain.

Ideally Gruntwork would need to publish terragrunt image to ghcr.io which then is used in action to solve this issue.

Or publish this action as dockerfile and then we use it with

- name: Plan terragrunt
  uses: docker://ghcr.io/gruntwork-io/terragrunt-action:{version}

which by the way is much more effective than what happens now when action must be prebuilt before each workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants