Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment variable (with default) to customize the container base image #30

Closed
wants to merge 3 commits into from

Conversation

bgolinvaux
Copy link

Added new base_image input, defaults to alpine:3.19

@ben-z
Copy link
Owner

ben-z commented Dec 1, 2024

Thanks for the PR! Does this work? Build args appear unsupported by GitHub: gruntwork-io/terragrunt-action#74 (comment)

@bgolinvaux
Copy link
Author

bgolinvaux commented Dec 1, 2024

I am truly sorry! (and terribly stupid). I have this habit of creating the PR right away when I start working, but I meant to create it in my repo, just to track the branch and then create another one in the upstream and, instead, I opened the PR in your repo and forgot to set it to draft.

Indeed, it does not work and I considered manually calling docker, but it's a PITA. I'll close it for now

Thanks for the mutex, btw, it's super handy!

@bgolinvaux bgolinvaux marked this pull request as draft December 1, 2024 18:52
@bgolinvaux bgolinvaux closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants