Introduce concept of merge strategy for includes #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
force-pushed
the
yori-merge-strategy
branch
from
0d756e6 to
f69e4da
Compare
yorinasub17
force-pushed
the
yori-merge-strategy
branch
3 times, most recently
from
f8c48d7 to
815da32
Compare
yorinasub17
force-pushed
the
yori-merge-strategy
branch
from
815da32 to
5f18f90
Compare
brikis98
approved these changes
Jul 29, 2021
| @@ -203,6 +204,29 @@ func (cfg *IncludeConfig) GetExpose() bool { | |||
| return *cfg.Expose | |||
| } | |||
|
|
|||
| func (cfg *IncludeConfig) GetMergeStrategy() (MergeStrategyType, error) { | |||
There was a problem hiding this comment.
Is this necessary because you can't set the type of MergeStrategy to *MergeStrategyType in IncludeConfig? I guess the HCL parser doesn't know how to parse a string into that type?
There was a problem hiding this comment.
Yup... unfortunately.
|
Thanks for review! Will merge now. |
This was referenced Jul 29, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new attribute
merge_strategytoincludeblocks, allowing you to specify anincludeblock without merging the config in. This can be used in conjunction with the newexposeattribute to simulateread_terragrunt_configfor certain use cases. Note that due to the limitation of single include blocks, it is not a full replacement forread_terragrunt_config(yet).This PR also refactors the merge functionality of the config into a new
include.gofile. This is in preparation for the next PR after this one, which will introduce deep merge strategy.