#1891 Dependent modules detection update #1915
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
requested review from
bwhaley,
rhoboat,
yorinasub17 and
zackproser
as code owners
brikis98
reviewed
Nov 16, 2021
| @@ -577,7 +577,8 @@ func FindWhereWorkingDirIsIncluded(terragruntOptions *options.TerragruntOptions, | |||
| dir = dir + filepath.FromSlash("/") | |||
| cfgOptions, err := options.NewTerragruntOptions(dir) | |||
| if err != nil { | |||
| return nil, err | |||
| terragruntOptions.Logger.Debugf("Failed to build terragrunt options from %s %v", dir, err) | |||
There was a problem hiding this comment.
This seems like a real error that should probably be returned?
| return nil, err | ||
| // loggign error as debug since in some cases stack building may fail because parent files can be designed | ||
| // to work with relative paths from downstream modules | ||
| terragruntOptions.Logger.Debugf("Failed to build module stack %v", err) |
There was a problem hiding this comment.
Is this the real fix for this issue? Where we don't return an error in this case?
brikis98
approved these changes
Nov 18, 2021
|
Tests passed! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FindWhereWorkingDirIsIncluded to return only detected dependent modules, in case of failures user will be asked to confirm the action in any case.
Fix for: #1891