Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passing of options to RunHelmCommandAndGetOutputE #1276

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Apr 28, 2023

Description

Updated Helm installation function to allow logs redirection.

Fixes #1273.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated Helm chart installation to allow logs redirection

Migration Guide

@denis256 denis256 marked this pull request as ready for review April 28, 2023 21:33
@denis256 denis256 requested a review from zackproser as a code owner April 28, 2023 21:33
@denis256 denis256 changed the title [WIP] Add passing of options to RunHelmCommandAndGetOutputE Add passing of options to RunHelmCommandAndGetOutputE Apr 28, 2023
@denis256 denis256 merged commit 56940d5 into master Apr 30, 2023
@denis256 denis256 deleted the bug/options-passing-1273 branch April 30, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm.Options.Logger option is ignored when building dependencies
2 participants