Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packer): support for template directories #1336

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NefixEstrada
Copy link

Description

Fixes #1271

With this PR you can use directories for Packer templates

Release Notes (draft)

Added support for Packer template directories

@denis256
Copy link
Member

denis256 commented Sep 4, 2023

Hello,
Adding tests would ensure the ongoing functionality of these changes. Please consider including them. Thank you! 👍

@NefixEstrada
Copy link
Author

I'm not really sure how to add the tests, since this function calls the actual packer binary

@walbertus
Copy link

is this still ongoing? we need this because our packer template use multiple files

@NefixEstrada
Copy link
Author

We use this in production and works, however I didn't come around to write the tests

@walbertus
Copy link

@NefixEstrada do you mind if I take a look and try to create the test?

@NefixEstrada
Copy link
Author

@walbertus

Sure, go ahead!

Thanks,
Néfix

Signed-off-by: William Albertus Dembo <29192168+walbertus@users.noreply.github.com>
@NefixEstrada
Copy link
Author

Hello @denis256 , @walbertus has implemented the required tests. Could you take a look again at the MR?

Thank you,
Néfix

@walbertus
Copy link

any input @denis256 ?
I'm thinking of adding a mock here to check the binary call but can't find a way to do it.
Do you have test recommendations in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for packer init with multiple .hcl files
3 participants