Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error checking in recoveryservices.go #1419

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixed error checking in recoveryservices.go #1419

merged 1 commit into from
Jul 12, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jul 11, 2024 •
edited
Loading

Description

Fixed error checking in recoveryservices.go

Fixes #1418.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

levkohimins
levkohimins approved these changes Jul 12, 2024
View reviewed changes
Copy link

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 710d6af into master Jul 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkohimins levkohimins levkohimins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible condition in `modules/azure/recoveryservices.go#GetRecoveryServicesVaultBackupProtectedVMListE
2 participants
@denis256 @levkohimins