Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker login function #1450

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bablzz
Copy link

@Bablzz Bablzz commented Sep 27, 2024

Description

Hello folks!
Just added docker login for testing to push images to a private registry.
Only for testing purpose because use --password options.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added docker login

Migration Guide

@Bablzz Bablzz requested a review from denis256 as a code owner September 27, 2024 08:01
Copy link
Member

@denis256 denis256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure the long-term reliability of this feature, I recommend adding automated tests that specifically track the login functionality.

}

// login runs the 'docker login' command to login the given registry.
func login(t testing.TestingT, opt LoginOptions) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No public function which return error, similar to Push() / PushE()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants