fix(k8s): honor options.RestConfig in tunnel.ForwardPortE #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tunnel.ForwardPortE function does not honor the rest config configured inside the KubectlOptions. This leads to a mismatch with other functions. This commit uses the RestConfig if defined instead of getting a new one.
denis256
approved these changes
Dec 12, 2024
denis256
approved these changes
Dec 17, 2024
ZachGoldberg
approved these changes
Dec 17, 2024
Resonance1584
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tunnel.ForwardPortE function does not honor the rest config configured inside the KubectlOptions. This leads to a mismatch with other functions.
This commit uses the RestConfig if defined instead of getting a new one.
Description
Fixes #1463.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
fix(k8s): honor options.RestConfig in tunnel.ForwardPortE