Implement Functionality for S3BucketServerSideEncryption #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
reviewed
Dec 9, 2024
modules/aws/s3.go
Outdated
| @@ -478,6 +478,37 @@ func AssertS3BucketPolicyExistsE(t testing.TestingT, region string, bucketName s | |||
| return nil | |||
| } | |||
|
|
|||
| // AssertS3BucketServerSideEncryption checks if the given S3 bucket has a server side encryption configured using the given algorithm and fail the test if it does not | |||
| func AssertS3BucketServerSideEncryption(t testing.TestingT, region string, bucketName string, algorithm types.ServerSideEncryption) { | |||
There was a problem hiding this comment.
Unused function 'AssertS3BucketServerSideEncryption' - may be a problem if at some point, the function is removed and there will not be any test that fails
|
PTAL @denis256. Addressed your comments. |
james03160927
force-pushed
the
assert-sse
branch
from
ab7f77c to
a126205
Compare
james03160927
force-pushed
the
assert-sse
branch
from
a126205 to
485b3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1080
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide