Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for docker stop #430

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Adding support for docker stop #430

merged 3 commits into from
Jan 10, 2020

Conversation

dhwaneetbhatt
Copy link
Contributor

@dhwaneetbhatt dhwaneetbhatt commented Jan 7, 2020

Description

Adding support for docker stop command in the terratest docker API.

Github Issue

#421

pre-commit hook

git commit -m "Adding support for docker stop"
goimports................................................................Passed
[docker-stop-command 1cb9753] Adding support for docker stop
 2 files changed, 87 insertions(+)
 create mode 100644 modules/docker/stop.go
 create mode 100644 modules/docker/stop_test.go

Test Run output

https://gist.github.com/dhwaneetbhatt/018f0775493143b30b7b463deaa45e37

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just kicked off the build. I have two style nits that may improve maintainability, but is not critical if you don't have time to implement.

modules/docker/stop.go Outdated Show resolved Hide resolved
modules/docker/stop_test.go Show resolved Hide resolved
@yorinasub17
Copy link
Contributor

This looks good! Thanks for your patience working with me on improving the tests.

Going to kick off another build now, and will merge if it passes.

@yorinasub17
Copy link
Contributor

Build passed, so going to merge this. Thanks again for your contribution!

@yorinasub17 yorinasub17 merged commit f36a904 into gruntwork-io:master Jan 10, 2020
@dhwaneetbhatt dhwaneetbhatt deleted the docker-stop-command branch January 10, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants