Fix build error due to deleted module. Add pause_before to packer-basic-example. Shave other yaks. #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we sometimes get build failures such as: ``` TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: Reading package lists... TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: Reading package lists... TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: Building dependency tree... TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: Reading state information... TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: Calculating upgrade... TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: The following packages have been kept back: TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:17Z logger.go:66: 1611935117,,ui,message, amazon-ebs: linux-aws linux-headers-aws linux-image-aws TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,message, amazon-ebs: The following packages will be upgraded: TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,message, amazon-ebs: sudo tzdata TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,error,==> amazon-ebs: E: Could not open file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_i18n_Translation-en - open (2: No such file or directory) TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,error,==> amazon-ebs: E: Could not open file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_binary-amd64_Packages - open (2: No such file or directory) TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,message, amazon-ebs: 2 upgraded%!!(MISSING)(PACKER_COMMA) 0 newly installed%!!(MISSING)(PACKER_COMMA) 0 to remove and 3 not upgraded. TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,error,==> amazon-ebs: E: Could not open file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_xenial-backports_main_i18n_Translation-en - open (2: No such file or directory) TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,error,==> amazon-ebs: E: Could not open file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_xenial-backports_main_binary-amd64_Packages - open (2: No such file or directory) TestBuildPackerArtifactWithGit/ref-sha 2021-01-29T15:45:18Z logger.go:66: 1611935118,,ui,error,==> amazon-ebs: E: Could not open file ``` I _think_ this is due to the issue where you run `apt` too soon after boot...
|
Build failed because we were relying on the |
brikis98
changed the title
|
This is currently blocked due to gruntwork-io/fetch#87. |
|
FYI - gruntwork-io/fetch#87 has been fixed and released. |
This pulls in the latest version of fetch, which has a fix for the --branch param.
Indeed! I just released https://github.com/gruntwork-io/gruntwork-installer/releases/tag/v0.0.33 too, and now have updated this PR to use it to see if it fixes the build. |
brikis98
changed the title
|
Yay, tests passed! |
|
Thanks for the review! Merging now. |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues:
Fix a build failure where a module we rely on in CI was deleted.
Add
pause_beforetopacker-basic-example. Without this, we sometimes get build failures such as:I think this is due to the issue where you run
apttoo soon after boot...Update
gruntwork-installerversion to pick up a new version offetchthat fixes a bug with the--branchargument.Pick instance types dynamically for Packer builds, rather than hard-coding
t2.micro, ast2.microisn't available in all regions.Add more retries for yet more transient provider download issues.